Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote write config for mysql telegraf metrics #1561

Merged
merged 5 commits into from Apr 15, 2021

Conversation

npande
Copy link
Contributor

@npande npande commented Apr 15, 2021

Description

Fill in your description here.


Testing performed
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

Copy link
Contributor

@pmalek-sumo pmalek-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix yamllint issues.

deploy/helm/sumologic/values.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@pmalek-sumo pmalek-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to remove the trailing whitespace at line 1951

@@ -1949,6 +1949,47 @@ kube-prometheus-stack:
regex: (?:kafka_(broker_.*|controller_.*|java_lang_.*|partition_.*|purgatory_.*|network_.*|replica_.*|request_.*|topic_.*|topics_.*|zookeeper_.*))
sourceLabels: [__name__]

## MySQL Telegraf Metrics
## List of Metrics are on following github page:
## https://github.com/influxdata/telegraf/tree/master/plugins/inputs/mysql#metrics
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

master will move with time and we might end up with an incorrect link. Can we pin it to a concrete tag? e.g.
https://github.com/influxdata/telegraf/tree/v1.18.1/plugins/inputs/mysql#metrics ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@pmalek-sumo pmalek-sumo merged commit c482748 into main Apr 15, 2021
@pmalek-sumo pmalek-sumo deleted the npande_mysql_remotewrite branch April 15, 2021 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants