Enabling remote write for postgresql metrics #1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himanshu219
requested review from
andrzej-stencel,
frankreno,
kkujawa-sumo,
perk-sumo,
pmalek-sumo and
sumo-drosiek
as code owners
pmalek-sumo
suggested changes
Apr 16, 2021
deploy/helm/sumologic/values.yaml
Outdated
| remoteTimeout: 5s | ||
| writeRelabelConfigs: | ||
| - action: keep | ||
| regex: (?:postgresql_(blks_hit.*|blks_read.*|buffers_backend.*|buffers_checkpoint.*|buffers_clean.*|checkpoints_req.*|checkpoints_timed.*|db_size.*|deadlocks.*|flush_lag.*|heap_blks_hit.*|heap_blks_read.*|idx_blks_hit.*|idx_blks_read.*|idx_scan.*|idx_tup_fetch.*|idx_tup_read.*|index_size.*|n_dead_tup.*|n_live_tup.*|n_tup_del.*|n_tup_hot_upd.*|n_tup_ins.*|n_tup_upd.*|num_locks.*|numbackends.*|replay_lag.*|replication_delay.*|replication_lag.*|seq_scan.*|seq_tup_read.*|stat_ssl_compression_count.*|table_size.*|tup_deleted.*|tup_fetched.*|tup_inserted.*|tup_returned.*|tup_updated.*|write_lag.*|xact_commit.*|xact_rollback.*) |
There was a problem hiding this comment.
- This regex is invalid: it doesn't have an matching closing parenthesis.
- Do we need to add a wildcard to every single pattern here? I'd try to avoid that. If we can't then please update the comment above to reflect the asterisks in regexes.
There was a problem hiding this comment.
strange it didn't failed when I redeployed with this command
helm3 upgrade --install sumo-release sumologic/sumologic --namespace=sumo-collector --create-namespace -f sumologic-values.yaml --set telegraf-operator.enabled=true ...
Am I testing it correctly ? do I have to kill the postgresql pods?
There was a problem hiding this comment.
We should have as minimal regex (in terms of matches) as possible. We should avoid wildcard as @pmalek-sumo said.
pmalek-sumo
approved these changes
Apr 19, 2021
There was a problem hiding this comment.
👍 @sumo-drosiek any comments? I believe this is alright now
sumo-drosiek
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fill in your description here.
This PR enables metrics for PostgreSQL
Testing performed