-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Byi override yaml update #16
Conversation
deploy/helm/overrides.yaml
Outdated
@@ -1,56 +1,137 @@ | |||
prometheus: | |||
prometheusSpec: | |||
externalLabels: | |||
# Set this to a value to distinguish between different k8s clusters | |||
cluser: kubernetes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing the t in cluster
@ggarg2906sumo this change should fix all missing time series. These things need to be noticed:
|
why clone? why not set in helm overrides as it can override those value? |
I also think that due to the version change and use of many k8s versions in the wild, we should have an FAQ doc or something and just call this out specifically. |
I tried with make these changes into override.yaml, but it will not overwrite the original selector but add them as:
which will make the service is still not connected since the selector is actually working as |
Crap. I forgot about that bug in helm. Ok is what it is for the moment. |
[DV-5909] Add ADD ES collector
update yaml files for: