Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Byi override yaml update #16

Merged
merged 10 commits into from Apr 26, 2019
Merged

Byi override yaml update #16

merged 10 commits into from Apr 26, 2019

Conversation

bin3377
Copy link

@bin3377 bin3377 commented Apr 25, 2019

update yaml files for:

  • fix the changed name/job in metrics
  • add cluster label
  • remove cadvisor source since it's combined into kubelet

@@ -1,56 +1,137 @@
prometheus:
prometheusSpec:
externalLabels:
# Set this to a value to distinguish between different k8s clusters
cluser: kubernetes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing the t in cluster

@bin3377
Copy link
Author

bin3377 commented Apr 25, 2019

@ggarg2906sumo this change should fix all missing time series. These things need to be noticed:

  1. There is an incompatible between Prometheus-Operator chart and latest version of Kubernetes. So we need a workaround for install helm chart
    a) clone https://github.com/helm/charts/
    b) modify values.yaml in (path-to-charts-repo)/stable: find component: kube-controller-manager and replace to k8s-app: kube-controller-manager; find component: kube-scheduler and replace to k8s-app: kube-scheduler
    c) install chart with modified values.yaml with running following command in (path-to-charts-repo)/stable:
    helm install --namespace sumologic --name prometheus-operator ./prometheus-operator -f prometheus-operator/values.yaml -f (path-to-sumologic-kubernetes-collection)/deploy/helm/overrides.yaml --no-crd-hook

  2. time series in cadvisor is combined into kubelet

  3. some metrics name changed in node-exporter part

@frankreno
Copy link
Contributor

why clone? why not set in helm overrides as it can override those value?

@frankreno
Copy link
Contributor

I also think that due to the version change and use of many k8s versions in the wild, we should have an FAQ doc or something and just call this out specifically.

@bin3377
Copy link
Author

bin3377 commented Apr 25, 2019

I tried with make these changes into override.yaml, but it will not overwrite the original selector but add them as:

Name:              prometheus-operator-kube-controller-manager
...
Selector:          component=kube-controller-manager,k8s-app=kube-controller-manager

which will make the service is still not connected since the selector is actually working as AND

@frankreno
Copy link
Contributor

Crap. I forgot about that bug in helm. Ok is what it is for the moment.

@bin3377
Copy link
Author

bin3377 commented Apr 26, 2019

@lei-sumo @samjsong

@bin3377 bin3377 merged commit ac91bce into master Apr 26, 2019
@bin3377 bin3377 deleted the byi-override-yaml-update branch April 26, 2019 20:38
psaia pushed a commit to psaia/sumologic-kubernetes-collection that referenced this pull request May 25, 2021
[DV-5909] Add ADD ES collector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants