Git ignore Helm chart deps #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lei-sumo
reviewed
Aug 30, 2019
| @@ -16,3 +16,7 @@ Gemfile.lock | |||
|
|
|||
| # VS Code ignores | |||
| .vscode/* | |||
|
|
|||
| # Helm chart dependencies | |||
| deploy/helm/sumologic/charts | |||
There was a problem hiding this comment.
I don't even see these in our code base. Why do we need to exclude explicitly?
There was a problem hiding this comment.
they will be generated if you are developing (making changes to) our helm chart to test locally. We want to be sure to not check those in.
lei-sumo
approved these changes
Aug 30, 2019
psaia
pushed a commit
to psaia/sumologic-kubernetes-collection
that referenced
this pull request
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Same as
gh-pagesbranch but formasterbranch.Testing performed