Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin patch version of helm dependencies #178

Merged
merged 1 commit into from
Sep 6, 2019

Conversation

samjsong
Copy link
Contributor

@samjsong samjsong commented Sep 5, 2019

Description

We want to pin the stable versions that have been tested, including the patch version.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@samjsong
Copy link
Contributor Author

samjsong commented Sep 5, 2019

@frankreno what was the bug that you mentioned, where we'd want to pin 5.10.5 of the prometheus operator chart?

@frankreno
Copy link
Contributor

the issue was with the admissionWebook and helm template. We have hit other issues with webhook admission controller.

@frankreno
Copy link
Contributor

We can also go the route of documenting the issue

Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i am fine with going with 6.2.1, its been tested. We can document the other issues.

@samjsong samjsong merged commit b8ac0b9 into master Sep 6, 2019
@samjsong samjsong deleted the ssong-pin-helm-dependency-versions branch September 6, 2019 04:19
andrzej-stencel added a commit that referenced this pull request Apr 2, 2021
andrzej-stencel added a commit that referenced this pull request Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants