Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cluster name override instructions #189

Merged
merged 4 commits into from
Sep 12, 2019
Merged

Add cluster name override instructions #189

merged 4 commits into from
Sep 12, 2019

Conversation

maimaisie
Copy link
Contributor

Description

Fill in your description here.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

Copy link
Contributor

@drduke1 drduke1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed we have "-LJO" and in other places "- LJO" a space.

deploy/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@lei-sumo lei-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks @maimaisie

@maimaisie
Copy link
Contributor Author

@drduke1 I'm going to merge for now. If you have feedback we can open a followup PR

@maimaisie maimaisie merged commit 63f9680 into master Sep 12, 2019
@maimaisie maimaisie deleted the maimaisie-patch-1 branch September 12, 2019 22:49
psaia pushed a commit to psaia/sumologic-kubernetes-collection that referenced this pull request May 25, 2021
* remove corelight s3 source until we have a valid role

* remove corelight s3 source until we have a valid role
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants