Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency upgrades for ARM support #1919

Merged
merged 5 commits into from
Dec 1, 2021
Merged

Dependency upgrades for ARM support #1919

merged 5 commits into from
Dec 1, 2021

Conversation

swiatekm
Copy link

@swiatekm swiatekm commented Nov 30, 2021

Description

Updating some dependencies necessary for ARM support:

  • telegraf-operator from 1.2.0 to 1.3.3 (1.3.0 is when they added ARM support)
  • kube-state-metrics from implicit 1.9.7 to 1.9.8
  • kubernetes-setup to from 3.0.0 to 3.1.1
  • kubernetes-tools from 2.2.3 to 2.6.0

I updated the tools version to 2.6.0 everywhere we explicitly mention it in the documentation. I think this is fine, but let me know if you see some kind of problem.

Ran E2E tests on this and they passed.


Testing performed
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@github-actions github-actions bot added the documentation documentation label Nov 30, 2021
@swiatekm swiatekm marked this pull request as ready for review November 30, 2021 15:45
@swiatekm swiatekm requested a review from a team as a code owner November 30, 2021 15:45
Copy link
Contributor

@pmalek-sumo pmalek-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a Changelog entry with all those changes

@swiatekm swiatekm force-pushed the arm-upgrades branch 2 times, most recently from 62054ec to 2367f20 Compare December 1, 2021 11:24
@github-actions github-actions bot added the ci label Dec 1, 2021
Comment on lines 7 to 12
##### Checklist

Remove items which don't apply to your PR.

- [ ] Changelog updated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

piggybacking on this PR 🤔

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can submit this change separately if you want 🙄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better practice IMHO

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allright, see #1922

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@pmalek-sumo pmalek-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the PR template this looks really good 👍

Mikolaj Swiatek added 4 commits December 1, 2021 12:42
Telegraf-operator added ARM support in 1.3.0, and the Helm chart ties
the binary version to the chart version. Upgrade the chart so we can
run on ARM.
Use the gcr repo, which has ARM images starting from this version.
This gives us ARM support, primarily.
This includes ARM support and brings us closer to supporting the entirety of
collection on ARM.
@swiatekm swiatekm force-pushed the arm-upgrades branch 2 times, most recently from 7fd8801 to f1ffaeb Compare December 1, 2021 11:44
@swiatekm swiatekm enabled auto-merge (rebase) December 1, 2021 11:45
@swiatekm swiatekm merged commit 78f1fd0 into main Dec 1, 2021
@swiatekm swiatekm deleted the arm-upgrades branch December 1, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants