Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): add job and cronjob to clusterrole's permission set #1983

Merged

Conversation

pmalek-sumo
Copy link
Contributor

@pmalek-sumo pmalek-sumo commented Dec 14, 2021

This was observed when running integration tests with OTC:

E1214 14:59:05.716479       1 reflector.go:138] k8s.io/client-go@v0.22.4/tools/cache/reflector.go:167: Failed to watch *v1.Job: failed to list *v1.Job: jobs.batch is forbidden: User "system:serviceaccount:test-helm-default-ot-metadata-930:rel-1045518918-sumologic" cannot list resource "jobs" in API group "batch" at the
E1214 14:59:07.282898       1 reflector.go:138] k8s.io/client-go@v0.22.4/tools/cache/reflector.go:167: Failed to watch *v1.CronJob: failed to list *v1.CronJob: cronjobs.batch is forbidden: User "system:serviceaccount:test-helm-default-ot-metadata-930:rel-1045518918-sumologic" cannot list resource "cronjobs" in API grou

and reported internally by @sburton-sumo

@pmalek-sumo pmalek-sumo self-assigned this Dec 14, 2021
@pmalek-sumo pmalek-sumo marked this pull request as ready for review December 14, 2021 15:19
@pmalek-sumo pmalek-sumo requested a review from a team as a code owner December 14, 2021 15:19
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I'm 👍 but please update the changelog :)

@pmalek-sumo pmalek-sumo force-pushed the add-job-and-cronjob-permissions-to-clusterroles-definition branch from 7407a87 to 65e61ed Compare December 15, 2021 09:31
@github-actions github-actions bot added the documentation documentation label Dec 15, 2021
@pmalek-sumo pmalek-sumo enabled auto-merge (squash) December 15, 2021 09:32
@pmalek-sumo
Copy link
Contributor Author

@perk-sumo PTAL, added the changelog.

Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pmalek-sumo pmalek-sumo merged commit 04a1be0 into main Dec 17, 2021
@pmalek-sumo pmalek-sumo deleted the add-job-and-cronjob-permissions-to-clusterroles-definition branch December 17, 2021 09:33
@sumo-backporter
Copy link
Contributor

The backport to release-v2.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-v2.3 release-v2.3
# Navigate to the new working tree
cd .worktrees/backport-release-v2.3
# Create a new branch
git switch --create backport-1983-to-release-v2.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 04a1be0bbe4e30ea5d9971338875c140ec88c230
# Push it to GitHub
git push --set-upstream origin backport-1983-to-release-v2.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-v2.3

Then, create a pull request where the base branch is release-v2.3 and the compare/head branch is backport-1983-to-release-v2.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants