Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add batching to otelcol log collector #2018

Merged
merged 3 commits into from
Jan 11, 2022

Conversation

swiatekm
Copy link

@swiatekm swiatekm commented Jan 11, 2022

Description

Add a batch processor to the otelcol log collector's pipeline, in an attempt to make its semantics closer to Fluent-Bit's. batch_size is set to the same value as the metadata enricher.
timeout is set to the same value as fluent-bit's Flush.


Checklist

Remove items which don't apply to your PR.

  • Changelog updated
Testing performed
  • Confirm events, logs, and metrics are coming in

@swiatekm swiatekm changed the title feat: add batching to OTC log collector feat: add batching to otelcol log collector Jan 11, 2022
@swiatekm swiatekm force-pushed the feat/otelcol-log-collector-batch branch from beae76d to aedf870 Compare January 11, 2022 10:46
@github-actions github-actions bot added the documentation documentation label Jan 11, 2022
batch_size is set to the same value as the metadata enricher.

timeout is set to the same value as fluent-bit's Flush.
@swiatekm swiatekm force-pushed the feat/otelcol-log-collector-batch branch from aedf870 to 1da566a Compare January 11, 2022 10:56
@swiatekm swiatekm marked this pull request as ready for review January 11, 2022 10:57
@swiatekm swiatekm requested a review from a team as a code owner January 11, 2022 10:57
Co-authored-by: Patryk Małek <pmalek@sumologic.com>
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit, otherwise 👍

Co-authored-by: Marcin Stozek <58700054+perk-sumo@users.noreply.github.com>
@swiatekm swiatekm merged commit bd9f862 into main Jan 11, 2022
@swiatekm swiatekm deleted the feat/otelcol-log-collector-batch branch January 11, 2022 12:11
@perk-sumo perk-sumo added this to the v2.4 milestone Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants