chore: add warning for increased cpu requests for Fluentds #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
I'm not sure if comment is enough. How about adding a section to docs? Performance or best practices? |
perk-sumo
force-pushed
the
perk-add-fluentd-cpu-limit-warn
branch
from
bb4bcf5
to
03a92f3
Compare
kkujawa-sumo
approved these changes
Feb 10, 2022
perk-sumo
force-pushed
the
perk-add-fluentd-cpu-limit-warn
branch
2 times, most recently
from
b89b728
to
d3047f7
Compare
pmalek-sumo
suggested changes
Feb 10, 2022
perk-sumo
force-pushed
the
perk-add-fluentd-cpu-limit-warn
branch
from
d3047f7
to
e5af522
Compare
pmalek-sumo
suggested changes
Feb 10, 2022
perk-sumo
force-pushed
the
perk-add-fluentd-cpu-limit-warn
branch
3 times, most recently
from
c423d90
to
edbca15
Compare
perk-sumo
force-pushed
the
perk-add-fluentd-cpu-limit-warn
branch
from
edbca15
to
ca0c803
Compare
pmalek-sumo
approved these changes
Feb 11, 2022
perk-sumo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HPA looks at request CPU for scaling.
Fluentd reaches 1 core at max.
Example:
When CPU request is set to eg.
3(or3000m) with HPA'stargetCPUUtilizationPercentage: 50means that HPA aims to get every Fluentd to 1.5 core utilization which won't happen.Hence it will not scale it out.
We should suggest to keep CPU request for Fluentd be
1000mat most.