feat(metrics): drop container label for non-container kube state metrics #2144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
pmalek-sumo
reviewed
Feb 23, 2022
CHANGELOG.md
Outdated
| @@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| - feat: add otelcol's liveness and readiness probes configuration [#2105][#2105] | |||
| - docs: add fluentd buffers vs DPM calculations info for metrics [#2128][#2128] | |||
| - feat(otelcol/metrics): adjust metric otelcol configuration [#2134][#2134] | |||
| - feat(metrics): drop container label for non-container kube state metrics [#2144][#2144] | |||
There was a problem hiding this comment.
I think it's more of a Changed entry, isn't it?
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
sumo-drosiek
force-pushed
the
drosiek-drop-container-labels
branch
from
f99e62e
to
ffe0e4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drop container label for non-container kube state metrics. It requires to extract
kube_pod_status_phasewhich shouldn't have container label but should havepod/servicelabels.Fixes #2097
Checklist
Remove items which don't apply to your PR.
Testing performed