Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable metrics/traces collection from instrumentation by default #2154

Merged
merged 28 commits into from Nov 30, 2022

Conversation

mat-rumian
Copy link
Contributor

@mat-rumian mat-rumian commented Feb 28, 2022

Description

It's time to enable tracing ingestion by default. OTC will be deployed with SKC by default.


Checklist

Remove items which don't apply to your PR.

  • Changelog updated
Testing performed
  • Deploy chart to cluster

@mat-rumian mat-rumian requested a review from a team as a code owner February 28, 2022 14:06
@mat-rumian mat-rumian changed the title [WIP] Enable traces ingestion by default Enable traces ingestion by default Mar 2, 2022
@mat-rumian mat-rumian changed the title Enable traces ingestion by default feat: enable traces ingestion by default Mar 2, 2022
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, before we can proceed with this need confirmation that this will not break current users who have tracing enabled.

@perk-sumo perk-sumo added this to the v3.0 milestone Mar 2, 2022
@mat-rumian
Copy link
Contributor Author

As we decided - PR postponed till 3.0

@mat-rumian mat-rumian changed the title feat: enable traces ingestion by default [WIP] feat: enable traces ingestion by default Mar 3, 2022
@mat-rumian mat-rumian changed the title [WIP] feat: enable traces ingestion by default feat: enable metrics/traces collection from instrumentation by default Nov 21, 2022
@github-actions github-actions bot added the documentation documentation label Nov 21, 2022
…ed-default

# Conflicts:
#	CHANGELOG.md
#	deploy/helm/sumologic/README.md
#	tests/integration/helm_opentelemetry_operator_enabled_test.go
#	tests/integration/helm_otc_fips_metadata_installation_test.go
#	tests/integration/helm_traces_enabled_test.go
#	tests/integration/values/values_common.yaml
@mat-rumian mat-rumian enabled auto-merge (squash) November 30, 2022 15:18
Copy link
Contributor

@swiatekm-sumo swiatekm-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mat-rumian mat-rumian merged commit e3ffe05 into main Nov 30, 2022
@mat-rumian mat-rumian deleted the feat-traces-otc-enabled-default branch November 30, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants