New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable metrics/traces collection from instrumentation by default #2154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, before we can proceed with this need confirmation that this will not break current users who have tracing enabled.
As we decided - PR postponed till 3.0 |
…ed-default # Conflicts: # CHANGELOG.md # deploy/helm/sumologic/README.md # tests/integration/helm_opentelemetry_operator_enabled_test.go # tests/integration/helm_otc_fips_metadata_installation_test.go # tests/integration/helm_traces_enabled_test.go # tests/integration/values/values_common.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Description
It's time to enable tracing ingestion by default. OTC will be deployed with SKC by default.
Checklist
Remove items which don't apply to your PR.
Testing performed