Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change otlp http receiver port - tracing #2170

Merged
merged 6 commits into from Mar 3, 2022

Conversation

mat-rumian
Copy link
Contributor

@mat-rumian mat-rumian commented Mar 2, 2022

Description

OTLP HTTP receiver port 55681 is deprecated. OT Collector is still exposing it but soon it will be off.

Collector log:

otelcol  | 2022-03-03T13:19:33.622Z     info    otlpreceiver/otlp.go:68 Starting GRPC server on endpoint 0.0.0.0:4317   {"kind": "receiver", "name": "otlp"}
otelcol  | 2022-03-03T13:19:33.622Z     info    otlpreceiver/otlp.go:86 Starting HTTP server on endpoint 0.0.0.0:4318   {"kind": "receiver", "name": "otlp"}
otelcol  | 2022-03-03T13:19:33.622Z     info    otlpreceiver/otlp.go:141        Setting up a second HTTP listener on legacy endpoint 0.0.0.0:55681      {"kind": "receiver", "name": "otlp"}
otelcol  | 2022-03-03T13:19:33.622Z     info    otlpreceiver/otlp.go:86 Starting HTTP server on endpoint 0.0.0.0:55681  {"kind": "receiver", "name": "otlp"}

Collector version: "v0.38.1-sumo"


Checklist

Remove items which don't apply to your PR.

  • Changelog updated
Testing performed
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@mat-rumian mat-rumian requested a review from a team as a code owner March 2, 2022 10:59
@sumo-drosiek
Copy link
Contributor

sumo-drosiek commented Mar 2, 2022

Please update changelog and add a semantic commit or PR title

@mat-rumian mat-rumian changed the title Change OTC OTLP HTTP receiver port feat: change otlp otlp http receiver port Mar 2, 2022
Copy link
Contributor

@pmalek-sumo pmalek-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from adding a changelog entry please add a note in description why this is needed. What caused us to change this etc.

@mat-rumian mat-rumian changed the title feat: change otlp otlp http receiver port feat: change otlp http receiver port Mar 2, 2022
@sumo-drosiek sumo-drosiek added this to the v2.6 milestone Mar 2, 2022
@pmalek-sumo
Copy link
Contributor

feat: change otlp http receiver port

Might be more specific so that people know it's only for tracing.

BTW: isn't that a breaking change for people already using our chart? Won't users need to adjust their setups to send on a different port?

@sumo-drosiek sumo-drosiek modified the milestones: v2.6, v2.7 Mar 3, 2022
@mat-rumian mat-rumian changed the title feat: change otlp http receiver port feat: change otlp http receiver port - tracing Mar 3, 2022
@mat-rumian
Copy link
Contributor Author

BTW: isn't that a breaking change for people already using our chart? Won't users need to adjust their setups to send on a different port?

No, because collector by default is opening deprecated port 55681. We are going to update our Tracing documentation with information that port 55681 will be deprecated and 4318 is the one to use.

@github-actions github-actions bot added the documentation documentation label Mar 3, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Dominik Rosiek <58699848+sumo-drosiek@users.noreply.github.com>
@mat-rumian mat-rumian merged commit cceeae9 into main Mar 3, 2022
@mat-rumian mat-rumian deleted the feat-otc-http-port-update branch March 3, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants