Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(otelcol): add startupProbe config option #2201

Merged
merged 1 commit into from Mar 21, 2022
Merged

feat(otelcol): add startupProbe config option #2201

merged 1 commit into from Mar 21, 2022

Conversation

pmalek-sumo
Copy link
Contributor

No description provided.

@pmalek-sumo pmalek-sumo self-assigned this Mar 17, 2022
@pmalek-sumo pmalek-sumo force-pushed the otelcol-introduce-startupProbe branch from 9916554 to f74137b Compare March 17, 2022 12:27
@github-actions github-actions bot added the documentation documentation label Mar 17, 2022
@pmalek-sumo pmalek-sumo marked this pull request as ready for review March 17, 2022 12:27
@pmalek-sumo pmalek-sumo requested a review from a team as a code owner March 17, 2022 12:27
@pmalek-sumo pmalek-sumo added this to the v2.7 milestone Mar 17, 2022
@sumo-drosiek
Copy link
Contributor

  1. how can it be disabled?
  2. add it to README.md please

@pmalek-sumo pmalek-sumo force-pushed the otelcol-introduce-startupProbe branch from f74137b to 448db83 Compare March 17, 2022 14:20
@pmalek-sumo
Copy link
Contributor Author

  1. with this approach you cannot but it's the same for liveness and readiness probes
  2. added

PTAL @sumo-drosiek

@pmalek-sumo pmalek-sumo merged commit 83f1856 into main Mar 21, 2022
@pmalek-sumo pmalek-sumo deleted the otelcol-introduce-startupProbe branch March 21, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions approved these changes

@swiatekm-sumo swiatekm-sumo swiatekm-sumo approved these changes

Assignees

@pmalek-sumo pmalek-sumo

Labels
documentation documentation
Projects
None yet
Milestone
v2.7
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pmalek-sumo @sumo-drosiek @swiatekm-sumo @pmalek