Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(notes): add information about tracing receiver endpoints #2209

Merged
merged 5 commits into from Jun 9, 2022
Merged

feat(notes): add information about tracing receiver endpoints #2209

merged 5 commits into from Jun 9, 2022

Conversation

mat-rumian
Copy link
Contributor

@mat-rumian mat-rumian commented Mar 22, 2022 •
edited

Description

Show available endpoints list to which traces can be sent after chart installation based on the installation type otelagent vs otelcol.

Checklist
  • Changelog updated
Testing performed
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@github-actions github-actions bot added the documentation documentation label Mar 22, 2022
@mat-rumian mat-rumian marked this pull request as ready for review June 9, 2022 08:14
@mat-rumian mat-rumian requested a review from a team as a code owner June 9, 2022 08:14
sumo-drosiek
sumo-drosiek approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add some kind of comment to otc service, that it should update NOTES.txt in case of changing ports ports, but generally LGTM

@mat-rumian mat-rumian enabled auto-merge (squash) June 9, 2022 08:24
@mat-rumian mat-rumian merged commit 3ee1623 into main Jun 9, 2022
@mat-rumian mat-rumian deleted the feat-add-endpoints-info branch June 9, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions approved these changes

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

Assignees
No one assigned
Labels
documentation documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mat-rumian @sumo-drosiek