Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metadata/otc): upgrade to v0.50.0-sumo-0 #2251

Merged
merged 9 commits into from May 5, 2022
Merged

Conversation

sumo-drosiek
Copy link
Contributor

@sumo-drosiek sumo-drosiek commented Apr 28, 2022

Description
  • Upgrade otc version to v0.49.0-sumo-0
  • Remove usage of metadata_attributes
  • Stop moving out record attributes for systemd
  • Move _collector to resource attributes for containers
  • remove k8s.pod.uid for vagrant
  • update docs for using containerd and fluent-bit
  • remove http_listener_v2_path in routing processor instead of exporter for metadata/metrics

Checklist
  • Changelog updated
Testing performed
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@sumo-drosiek sumo-drosiek requested a review from a team as a code owner April 28, 2022 06:53
@github-actions github-actions bot added the documentation documentation label Apr 28, 2022
@sumo-drosiek sumo-drosiek added this to the v2.8 milestone Apr 28, 2022
Copy link
Contributor

@swiatekm-sumo swiatekm-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to get rid of annotations: blocks from k8s_tagger configurations. These were unnecessary before, but now they're going to cause us to send more metadata than we need.

deploy/helm/sumologic/values.yaml Show resolved Hide resolved
@sumo-drosiek
Copy link
Contributor Author

sumo-drosiek commented Apr 28, 2022

We also need to get rid of annotations: blocks from k8s_tagger configurations. These were unnecessary before, but now they're going to cause us to send more metadata than we need.

isn't this a breaking change?

@swiatekm-sumo
Copy link
Contributor

We also need to get rid of annotations: blocks from k8s_tagger configurations. These were unnecessary before, but now they're going to cause us to send more metadata than we need.

isn't this a breaking change?

It is if the user added them to their metadata_attributes. In that sense, almost all changes in this PR are breaking.

@sumo-drosiek
Copy link
Contributor Author

We also need to get rid of annotations: blocks from k8s_tagger configurations. These were unnecessary before, but now they're going to cause us to send more metadata than we need.

isn't this a breaking change?

It is if the user added them to their metadata_attributes. In that sense, almost all changes in this PR are breaking.

I was thinking rather that we have been sending pod annotations and we stop sending them with this change

@swiatekm-sumo
Copy link
Contributor

I was thinking rather that we have been sending pod annotations and we stop sending them with this change

We haven't, though. We didn't have the annotations in metadata_attributes anywhere, so it didn't get sent.

@sumo-drosiek
Copy link
Contributor Author

I was thinking rather that we have been sending pod annotations and we stop sending them with this change

We haven't, though. We didn't have the annotations in metadata_attributes anywhere, so it didn't get sent.

We are using json, so if the annotations were in the any of the attributes, they were send as part of log

@swiatekm-sumo
Copy link
Contributor

I was thinking rather that we have been sending pod annotations and we stop sending them with this change

We haven't, though. We didn't have the annotations in metadata_attributes anywhere, so it didn't get sent.

We are using json, so if the annotations were in the any of the attributes, they were send as part of log

If metadata_attributes were defined, then only attributes that matched any of the entries were sent, to my best understanding. See: https://github.com/SumoLogic/sumologic-otel-collector/blob/9923b89a506617689fcec94c1f85c0a3e7770c86/pkg/exporter/sumologicexporter/exporter.go#L292.

@swiatekm-sumo
Copy link
Contributor

Ok, you're talking about record attributes, makes sense. In that sense it is a breaking change and quite annoying to deal with, as I don't think there's a processor to move attributes from the resource level to the record level.

sumo-drosiek and others added 5 commits April 29, 2022 11:47
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
…processor

Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
@sumo-drosiek
Copy link
Contributor Author

also we use pod_annotations in sourceprocessor in order to overwrite _source* configuration

@sumo-drosiek
Copy link
Contributor Author

also filtering needs to be fixed as "" regexp catches ecerything

@swiatekm-sumo
Copy link
Contributor

Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
@swiatekm-sumo swiatekm-sumo self-requested a review May 4, 2022 13:12
Copy link
Contributor

@swiatekm-sumo swiatekm-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added dropping the Pod annotation from resource attributes in fix: drop Pod annotation attributes for container logs, the rest looks good to me.

deploy/helm/sumologic/values.yaml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@sumo-drosiek sumo-drosiek changed the title feat(metadata/otc): upgrade to v0.49.0-sumo-0 feat(metadata/otc): upgrade to v0.50.0-sumo-0 May 4, 2022
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
@swiatekm-sumo swiatekm-sumo self-requested a review May 4, 2022 15:14
@sumo-drosiek sumo-drosiek merged commit 001536b into main May 5, 2022
@sumo-drosiek sumo-drosiek deleted the drosiek-bump-sumo branch May 5, 2022 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants