New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metadata/otc): upgrade to v0.50.0-sumo-0 #2251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to get rid of annotations:
blocks from k8s_tagger configurations. These were unnecessary before, but now they're going to cause us to send more metadata than we need.
isn't this a breaking change? |
4993e35
to
1888b0b
Compare
It is if the user added them to their |
I was thinking rather that |
We haven't, though. We didn't have the annotations in |
We are using |
If |
Ok, you're talking about record attributes, makes sense. In that sense it is a breaking change and quite annoying to deal with, as I don't think there's a processor to move attributes from the resource level to the record level. |
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
…processor Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
1888b0b
to
227fd0b
Compare
also we use |
also filtering needs to be fixed as "" regexp catches ecerything |
I'm pretty sure that's the same behaviour as exclusion in |
@swiatekm-sumo for |
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
5732677
to
0135eb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added dropping the Pod annotation from resource attributes in fix: drop Pod annotation attributes for container logs, the rest looks good to me.
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Description
metadata_attributes
_collector
to resource attributes for containersk8s.pod.uid
for vagranthttp_listener_v2_path
in routing processor instead of exporter for metadata/metricsChecklist
Testing performed