check exact secret name in setup script #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvmiller89
approved these changes
Oct 7, 2019
maimaisie
approved these changes
Oct 7, 2019
|
Thanks. We needed this patch. |
psaia
pushed a commit
to psaia/sumologic-kubernetes-collection
that referenced
this pull request
May 25, 2021
* add collectors for fastly-mobile-feedlocator and add said collectors to role * add dev * join might need to be interpolated * might have to try heredoc after all
andrzej-stencel
added a commit
that referenced
this pull request
Jul 15, 2021
Changes since v1.12.2-sumo-0: - feat: Build images for ARM #187 - chore(deps): bump fluent/fluentd from v1.12.2-debian-1.0 to v1.12.2-debian-1.1 #195 - chore(deps): Upgrade `rexml` gem to 3.2.5 fix CVE-2021-28965 #205 #206 #209 - chore(deps): Upgrade `rdoc` gem to 6.3.1 to fix CVE-2021-31799 #227 - chore(deps): Upgrade `addressable` gem to 2.8.0 to fix a vulnerability reported by Sysdig #292 #293 #294 #296 - chore(deps): Upgrade `ruby` in builder image from 2.6.6 to 2.6.8 #296 - chore(deps): Upgrade all system packages in Docker image #296
andrzej-stencel
added a commit
that referenced
this pull request
Jul 16, 2021
Changes since v1.12.2-sumo-0: - feat: Build images for ARM #187 - chore(deps): bump fluent/fluentd from v1.12.2-debian-1.0 to v1.12.2-debian-1.1 #195 - chore(deps): Upgrade `rexml` gem to 3.2.5 fix CVE-2021-28965 #205 #206 #209 - chore(deps): Upgrade `rdoc` gem to 6.3.1 to fix CVE-2021-31799 #227 - chore(deps): Upgrade `addressable` gem to 2.8.0 to fix a vulnerability reported by Sysdig #292 #293 #294 #296 - chore(deps): Upgrade `ruby` in builder image from 2.6.6 to 2.6.8 #296 - chore(deps): Upgrade all system packages in Docker image #296
sumo-backporter bot
pushed a commit
that referenced
this pull request
Jul 16, 2021
Changes since v1.12.2-sumo-0: - feat: Build images for ARM #187 - chore(deps): bump fluent/fluentd from v1.12.2-debian-1.0 to v1.12.2-debian-1.1 #195 - chore(deps): Upgrade `rexml` gem to 3.2.5 fix CVE-2021-28965 #205 #206 #209 - chore(deps): Upgrade `rdoc` gem to 6.3.1 to fix CVE-2021-31799 #227 - chore(deps): Upgrade `addressable` gem to 2.8.0 to fix a vulnerability reported by Sysdig #292 #293 #294 #296 - chore(deps): Upgrade `ruby` in builder image from 2.6.6 to 2.6.8 #296 - chore(deps): Upgrade all system packages in Docker image #296
andrzej-stencel
added a commit
that referenced
this pull request
Jul 16, 2021
Changes since v1.12.2-sumo-0: - feat: Build images for ARM #187 - chore(deps): bump fluent/fluentd from v1.12.2-debian-1.0 to v1.12.2-debian-1.1 #195 - chore(deps): Upgrade `rexml` gem to 3.2.5 fix CVE-2021-28965 #205 #206 #209 - chore(deps): Upgrade `rdoc` gem to 6.3.1 to fix CVE-2021-31799 #227 - chore(deps): Upgrade `addressable` gem to 2.8.0 to fix a vulnerability reported by Sysdig #292 #293 #294 #296 - chore(deps): Upgrade `ruby` in builder image from 2.6.6 to 2.6.8 #296 - chore(deps): Upgrade all system packages in Docker image #296
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
kubectl describe secret sumologicwill return results if you have any secret whose name starts withsumologicso if you have any secret named
sumologic.*, the setup script will fail. On the other hand,kubectl describe secret/sumologicwill only return results for an exact match on a secret namedsumologic.Testing performed