Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(otellogs): set fingerprint_size to 17k to include timestamp for docker driver #2325

Merged
merged 5 commits into from Jul 1, 2022

Conversation

sumo-drosiek
Copy link
Contributor

@sumo-drosiek sumo-drosiek commented Jun 1, 2022

Description

set fingerprint_size to 17k to include timestamp for docker driver

Upstream PR: open-telemetry/opentelemetry-collector-contrib#10485


Checklist
  • Changelog updated
Testing performed
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

…docker driver

Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
@sumo-drosiek sumo-drosiek requested a review from a team as a code owner June 1, 2022 13:19
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
@sumo-drosiek sumo-drosiek added this to the v2.10 milestone Jun 1, 2022
@github-actions github-actions bot added the documentation documentation label Jun 1, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains invalid labels. Please remove all of the following labels: ['do-not-merge/hold']

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains invalid labels. Please remove all of the following labels: ['do-not-merge/hold']

@sumo-drosiek
Copy link
Contributor Author

it's waiting for otelcol to support this value/changing value for existing configuration

@sumo-drosiek
Copy link
Contributor Author

Waiting for #2338

@swiatekm-sumo
Copy link
Contributor

Link the upstream issue in the comment as well?

sumo-drosiek and others added 2 commits June 30, 2022 09:35
@sumo-drosiek sumo-drosiek enabled auto-merge (squash) July 1, 2022 12:02
@sumo-drosiek sumo-drosiek merged commit d9c926b into main Jul 1, 2022
@sumo-drosiek sumo-drosiek deleted the drosiek-docker-fingerprint branch July 1, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants