Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding toleration and affinity #2428

Merged
merged 7 commits into from
Jul 15, 2022

Conversation

severity1
Copy link
Contributor

Description

Adding the ability to configure toleration and affinity to the setup job.

@severity1 severity1 requested a review from a team as a code owner July 14, 2022 11:11
@severity1 severity1 closed this Jul 14, 2022
@severity1 severity1 reopened this Jul 14, 2022
@github-actions github-actions bot added the documentation documentation label Jul 14, 2022
@severity1
Copy link
Contributor Author

this fixes issue #2424

Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@severity1 Thank you for the contribution

It would be awesome if you add missing configuration to chart's README.md as well

@severity1
Copy link
Contributor Author

@severity1 Thank you for the contribution
It would be awesome if you add missing configuration to chart's README.md as well

Hi @sumo-drosiek, README.md has been updated.

Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I will fix the non-related markdown table changes in separate PR

@sumo-drosiek
Copy link
Contributor

sumo-drosiek commented Jul 15, 2022

Thank you, I will fix the non-related markdown table changes in separate PR

I won't as this is required check 😅

I added two small suggestion and we are ready to go

CHANGELOG.md Outdated Show resolved Hide resolved
severity1 and others added 2 commits July 15, 2022 17:30
Co-authored-by: Dominik Rosiek <58699848+sumo-drosiek@users.noreply.github.com>
Co-authored-by: Dominik Rosiek <58699848+sumo-drosiek@users.noreply.github.com>
@sumo-drosiek
Copy link
Contributor

@severity1 Thanks for quick reaction, we just need to reformat table. If you have some automation tool it would be better to use, otherwise I hope the latest suggestion will resolve the issue

@severity1
Copy link
Contributor Author

@sumo-drosiek, thank you for your patience with me, I ran my auto-formatter against the README.md and it still gives an error.

@sumo-drosiek
Copy link
Contributor

@severity1

Seems like headers are the issue, as I run ./ci/markdown_table_formatter.sh --format, it replaced spaces to - locally

@severity1
Copy link
Contributor Author

I think I found the issue

@severity1
Copy link
Contributor Author

my IDE was converting --|-- to - | -

@sumo-drosiek sumo-drosiek enabled auto-merge (squash) July 15, 2022 05:59
@sumo-drosiek sumo-drosiek merged commit 22da7fc into SumoLogic:main Jul 15, 2022
@sumo-drosiek
Copy link
Contributor

my IDE was converting --|-- to - | -

Yes, this was the issue. Apparently ./ci/markdown_table_formatter.sh doesn't like it

@severity1
Copy link
Contributor Author

thank you @sumo-drosiek cheers!

@severity1 severity1 deleted the severity1-fix-2424 branch July 15, 2022 06:04
@sumo-drosiek
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants