Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(priorityclass): add priority class for logs and traces daemonsets #2433

Merged
merged 8 commits into from Jul 15, 2022

Conversation

mat-rumian
Copy link
Contributor

@mat-rumian mat-rumian commented Jul 14, 2022

Description

PR adds by default PriorityClass to Traces and Logs agents running as daemonset.


Checklist
  • Changelog updated
Testing performed
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@mat-rumian mat-rumian requested a review from a team as a code owner July 14, 2022 13:35
@github-actions github-actions bot added the documentation documentation label Jul 14, 2022
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add some documentation about it, especially how to add it to fluent-bit

At least add it to README:

https://github.com/fluent/helm-charts/blob/c6768cca7f72514bb906a432c961da17a1182350/charts/fluent-bit/values.yaml#L224

Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mat-rumian mat-rumian merged commit d99c729 into main Jul 15, 2022
@mat-rumian mat-rumian deleted the feat-priority-classes branch July 15, 2022 08:50
kkujawa-sumo added a commit to SumoLogic/sumologic-kubernetes-collection-helm-operator that referenced this pull request Aug 2, 2022
kkujawa-sumo added a commit to SumoLogic/sumologic-kubernetes-collection-helm-operator that referenced this pull request Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants