Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile changes for Terraform support #248

Merged
merged 3 commits into from Oct 23, 2019
Merged

Conversation

maimaisie
Copy link
Contributor

@maimaisie maimaisie commented Oct 21, 2019

Description

Dockerfile changes to install Terraform dependencies.

This needs to be merged and docker image built with a new Helm chart release before we can merge #249

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rvmiller89
Copy link
Contributor

Going to wait until EoD to merge, since we discovered a bug in TF source import and may need to bump the version.

@maimaisie maimaisie mentioned this pull request Oct 23, 2019
3 tasks
@rvmiller89 rvmiller89 merged commit 008a0a3 into master Oct 23, 2019
@rvmiller89 rvmiller89 deleted the maisie-tf-dockerfile branch October 23, 2019 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants