feat: enable remote write proxy by default #2483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
sumo-drosiek
approved these changes
Aug 22, 2022
swiatekm
force-pushed
the
feat/remote-write-proxy-by-default
branch
2 times, most recently
from
43f83c3
to
e6d9374
Compare
swiatekm
force-pushed
the
feat/remote-write-proxy-by-default
branch
from
e6d9374
to
7a054ba
Compare
swiatekm
force-pushed
the
feat/remote-write-proxy-by-default
branch
from
7a054ba
to
a682b9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remote write proxy helps metrics metadata enrichment efficiency by a lot, especially for larger clusters. It comes at a slight additional operational cost of the nginx Deployment, and a minimal resource cost. We've been running it in production for the past 6 months and never had any issue, so I believe we should enable it by default.
This isn't a breaking change, but it enables a new component, so I'm tagging it for v3.
Checklist
Testing performed