Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(setup): allow credentials to not be set if setup is disabled #2572

Merged
merged 1 commit into from Oct 18, 2022

Conversation

swiatekm-sumo
Copy link
Contributor

@swiatekm-sumo swiatekm-sumo commented Oct 17, 2022

Description

A recent change moved setup credentials to a temporary Secret, but failed to make this Secret conditional on setup being enabled. As a result, it's necessary to provide credentials even if setup is disabled, which is incorrect.

This PR doesn't include a test because our Helm template test framework doesn't allow not setting credentials in tests. I'll look into adding a test using Terratest instead in a separate PR.


Checklist
  • Changelog updated

A recent change moved setup credentials to a temporary Secret, but
failed to make this Secret conditional on setup being enabled. As
a result, it's necessary to provide credentials even if setup is
disabled, which is incorrect.
@swiatekm-sumo swiatekm-sumo marked this pull request as ready for review October 17, 2022 12:31
@swiatekm-sumo swiatekm-sumo requested a review from a team as a code owner October 17, 2022 12:31
@github-actions github-actions bot added the documentation documentation label Oct 17, 2022
@swiatekm-sumo swiatekm-sumo changed the title fix: allow credentials to not be set if setup is disabled fix(setup): allow credentials to not be set if setup is disabled Oct 17, 2022
@swiatekm-sumo swiatekm-sumo merged commit c49c407 into main Oct 18, 2022
@swiatekm-sumo swiatekm-sumo deleted the fix/setup-disabled-credentials branch October 18, 2022 11:54
@sumo-backporter
Copy link
Contributor

The backport to release-v2 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-v2 release-v2
# Navigate to the new working tree
cd .worktrees/backport-release-v2
# Create a new branch
git switch --create backport-2572-to-release-v2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c49c4073d224737e66cbfcc9e693791173196850
# Push it to GitHub
git push --set-upstream origin backport-2572-to-release-v2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-v2

Then, create a pull request where the base branch is release-v2 and the compare/head branch is backport-2572-to-release-v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants