chore(opentelemetry-operator): upgrade opentelemetry-operator subchart #2577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t to 0.13.0 (#2561) * chore(chart): update version * chore(tls): remove certificate creation, supported by operator chart * chore(clusterole): add opentelemetry-operator api group * chore(instrumentation): add instrumentation configmap and job * chore(instrumentatio-cr): move instrumentation cr to confs * chore(tests): update tests * chore(opentelemetry-operator): split instrumentation resource creation * chore(readme): update parameters list (cherry picked from commit d4d7599)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -303,8 +303,8 @@ The following table lists the configurable parameters of the Sumo Logic chart an | |||
| | `telegraf-operator.default` | Name of the default output configuration. | `sumologic-prometheus` | | |||
| | `telegraf-operator.data` | Telegraf sidecar configuration. | See [values.yaml] | | |||
| | `opentelemetry-operator.enabled` | Flag to control deploying OpenTelemetry Operator Helm sub-chart. | `false` | | |||
| | `opentelemetry-operator.createDefaultInstrumentation` | Flag to control creation of default Instrumentation object | `true` | | |||
| | `opentelemetry-operator.manager.env.WATCH_NAMESPACE` | Used to set value for `WATCH_NAMESPACE` environment variable which specifies Namespace to watch and create Instrumentation objects. | `Nil` | | |||
| | `opentelemetry-operator.createDefaultInstrumentation` | Flag to control creation of default Instrumentation object | `false` | | |||
There was a problem hiding this comment.
Isn't this kind of a breaking change? 😅
There was a problem hiding this comment.
Yeah, that seems like a breaking change to me to.
There was a problem hiding this comment.
Could be a breaking change, but we were treating OT Operator for Tracing as BETA. Appropriate comments in the next PR with changelog and release description will be added about this change.
| admissionWebhooks: | ||
| failurePolicy: Fail | ||
| enabled: false | ||
| enabled: true |
There was a problem hiding this comment.
Isn't this a breaking change?
There was a problem hiding this comment.
It's not as in version before admissionWebhooks were created by us with certificates.
perk-sumo
approved these changes
Oct 20, 2022
andrzej-stencel
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(cherry picked from commit d4d7599)
This PR:
InstrumentationCR generation to confs (config map created for this purpose)Instrumentationresource -opentelemetry-operator.createDefaultInstrumentation=falseopentelemetry-operator.instrumentationNamespacesparameter forInstrumentationresource creationChecklist
Testing performed