Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing all references of the PodSecurityPolicy for fluentd #2605

Merged
merged 1 commit into from Nov 14, 2022

Conversation

rnishtala-sumo
Copy link
Contributor

@rnishtala-sumo rnishtala-sumo commented Nov 11, 2022

Description

This PR removes the podSecurityPoliciy for fluend resources. Perhaps this isn't needed, wanted get some thoughts on this.


Checklist
  • Changelog updated
Testing performed
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@github-actions github-actions bot added the documentation documentation label Nov 11, 2022
@rnishtala-sumo rnishtala-sumo marked this pull request as ready for review November 11, 2022 17:09
@rnishtala-sumo rnishtala-sumo requested a review from a team as a code owner November 11, 2022 17:09
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider backward compatibility for k8s < 1.25

@swiatekm-sumo
Copy link
Contributor

I would consider backward compatibility for k8s < 1.25

You mean like retaining the PodSecurityPolicies for k8s < 1.25? Does that actually serve any practical purpose?

I think we should just mark this as a breaking change and be done with it.

@rnishtala-sumo
Copy link
Contributor Author

rnishtala-sumo commented Nov 14, 2022

@sumo-drosiek @swiatekm-sumo have we decided that this will be a breaking change and can be removed, or do we need to think about backward compatibility?

@sumo-drosiek
Copy link
Contributor

@sumo-drosiek @swiatekm-sumo have we decided that this will be a breaking change and can be removed, or do we need to think about backward compatibility?

Let's make it breaking change. We can always re-add it

@rnishtala-sumo rnishtala-sumo merged commit 5353114 into main Nov 14, 2022
@rnishtala-sumo rnishtala-sumo deleted the rnishtala-remove-psp branch November 14, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants