feat: add parameter to configure additional Prometheus remote writes #2611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
kkujawa-sumo
force-pushed
the
kk-add-additional-remote-parameter
branch
from
f25bd98
to
cc09b6d
Compare
swiatekm-sumo
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1480
I've found that
additionalRemoteWriteparametr is already mentioned in our documentation:https://github.com/SumoLogic/sumologic-kubernetes-collection/blob/main/deploy/docs/additional_prometheus_configuration.md#filter-metrics
remoteWriteparameter is mentioned in following docs and I think that it doesn't need to be changed toadditionalRemoteWrite: