feat(logs)!: simplify metadata configuration #2626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
swiatekm-sumo
force-pushed
the
feat/logs-metadata-config
branch
4 times, most recently
from
9413cad
to
3ecc55c
Compare
|
Could you add to the changelog below note or something similar? "Removed explicit configuration for otelcol under |
I can start a section for log config changes in the migration doc, but it'd just be the start. |
swiatekm-sumo
force-pushed
the
feat/logs-metadata-config
branch
from
3ecc55c
to
f2cdd9a
Compare
swiatekm-sumo
force-pushed
the
feat/logs-metadata-config
branch
3 times, most recently
from
14fb64c
to
8d9202a
Compare
1 task
swiatekm-sumo
force-pushed
the
feat/logs-metadata-config
branch
from
8d9202a
to
ae8d028
Compare
swiatekm-sumo
force-pushed
the
feat/logs-metadata-config
branch
from
ae8d028
to
037f630
Compare
swiatekm-sumo
changed the title
Co-authored-by: Andrzej Stencel <astencel@sumologic.com>
kkujawa-sumo
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move the logs metadata configuration to a template. We don't do much more here, there are more changes expected later, pulling out some of the configuration to top-level properties. I did make the configuration for containers and systemd conditional, same for the pipelines for otel log collector and Fluent Bit.
I've added two different ways of customizing the configuration directly. The contents of metadata.metrics.config.merge will be merged into the templated configuration, while metadata.metrics.config.override will replace it in total.
Migration can be found here: SumoLogic/sumologic-kubernetes-tools#387.
Checklist