Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update opentelemetry-operator chart and fix progagators list in instrumentation resource #2628

Merged
merged 10 commits into from Nov 23, 2022
Merged

feat: update opentelemetry-operator chart and fix progagators list in instrumentation resource #2628

merged 10 commits into from Nov 23, 2022

Conversation

mat-rumian
Copy link
Contributor

@mat-rumian mat-rumian commented Nov 23, 2022 •
edited

Description

PR:

  • updates OpenTelemetry-Operator chart
  • fixes lack of propagators in some of the instrumentation
  • sets exact image tag for instrumentation cr job
  • updates ot operator dotnet instrumentation img
Checklist
  • Changelog updated
Testing performed
  • OpenTelemetry-Operator Python instrumentation test
  • OpenTelemetry-Operator NodeJS instrumentation test
  • OpenTelemetry-Operator Java instrumentation test
  • OpenTelemetry-Operator Dotnet instrumentation test
  • OpenTelemetry-Operator Instrumentation Resource creation test

@mat-rumian mat-rumian changed the title feat: opentelemetry-operator update and propagators list fix feat: update opentelemetry-operator chart and fix progagators list in instrumentation resource Nov 23, 2022
@github-actions github-actions bot added the documentation documentation label Nov 23, 2022
@mat-rumian mat-rumian marked this pull request as ready for review November 23, 2022 14:46
@mat-rumian mat-rumian requested a review from a team as a code owner November 23, 2022 14:46
@mat-rumian mat-rumian merged commit 915b0f7 into main Nov 23, 2022
@mat-rumian mat-rumian deleted the mat-rumian-small-impr branch November 23, 2022 15:22
kkujawa-sumo
kkujawa-sumo reviewed Nov 23, 2022
View reviewed changes
deploy/helm/sumologic/values.yaml
## ref: https://github.com/open-telemetry/opentelemetry-helm-charts/tree/main/charts/opentelemetry-operator
opentelemetry-operator:
enabled: false

## Specific for Tracing - Instrumentation resource creation
## Specific for Sumo Logic chart - Instrumentation resource creation
instrumentationJobImage:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please all information about new parameters to https://github.com/SumoLogic/sumologic-kubernetes-collection/blob/main/deploy/helm/sumologic/README.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catch Kasia I will create a separated PR for that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkujawa-sumo kkujawa-sumo kkujawa-sumo left review comments

@github-actions github-actions[bot] github-actions approved these changes

@swiatekm-sumo swiatekm-sumo swiatekm-sumo approved these changes

Assignees
No one assigned
Labels
documentation documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mat-rumian @kkujawa-sumo @swiatekm-sumo