Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helper template variables #267

Merged
merged 1 commit into from Oct 30, 2019
Merged

Conversation

rvmiller89
Copy link
Contributor

Description

In case we can't get #266 to work

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@djsly
Copy link
Contributor

djsly commented Oct 30, 2019

This goes with #265, since nindent is now used, the strings should now have leading spaces

@djsly
Copy link
Contributor

djsly commented Oct 30, 2019

@rvmiller89 when you get a chance to merge this, could we release an alpha tag to allow a public chart to be accessible? our logic is currently based on your public helm REPO and I don't have an easy way to inject local charts into my pipelines.

@rvmiller89 rvmiller89 merged commit abe4f50 into master Oct 30, 2019
@rvmiller89 rvmiller89 deleted the rmiller-fix-helper-template branch October 30, 2019 21:11
@rvmiller89
Copy link
Contributor Author

@djsly I'll bring it up to the team about releasing Helm charts for alpha tag versions, right now I think our concern is that by publishing the alpha versions in https://github.com/SumoLogic/sumologic-kubernetes-collection/blob/gh-pages/index.yaml the default helm install sumologic/sumologic would download and install the latest alpha chart, rather than the stable tested release.

@djsly
Copy link
Contributor

djsly commented Oct 31, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants