feat(metrics): simplify custom application metrics #2716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
sumo-drosiek
changed the title
sumo-drosiek
force-pushed
the
drosiek-user-custom-metrics
branch
2 times, most recently
from
e1ac9e3
to
875fd43
Compare
sumo-drosiek
changed the title
@swiatekm-sumo I assume you were meaning |
| @@ -0,0 +1,15 @@ | |||
| kube-prometheus-stack: | |||
There was a problem hiding this comment.
It would be nicer if this was a Go test instead, we could avoid the output templates and just check if the servicemonitor names in the list are right.
sumo-drosiek
force-pushed
the
drosiek-user-custom-metrics
branch
2 times, most recently
from
0630627
to
dbbc48a
Compare
andrzej-stencel
approved these changes
Dec 22, 2022
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Co-authored-by: Mikołaj Świątek <mswiatek@sumologic.com>
Co-authored-by: Mikołaj Świątek <mswiatek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Co-authored-by: Andrzej Stencel <astencel@sumologic.com>
…true Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
sumo-drosiek
force-pushed
the
drosiek-user-custom-metrics
branch
from
21f7615
to
027f34f
Compare
Co-authored-by: Andrzej Stencel <astencel@sumologic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sumologic.metrics.serviceMonitorsto keep our serviceMonitors configurationadditionalServiceMonitorsempty, so customer doesn't need to copy anythingChecklist
Testing performed