feat: add metadata.metrics.config.extraProcessors #2724
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
tests/helm/metrics_test.go
Outdated
| require.Equal(t, renameMetadatatatements, otelConfig.Processors.RenameMetadata.MetricStatements[0].Statements) | ||
| } | ||
|
|
||
| func TestMetadataMetricsOtelConfigExtraProcessorsPipeline(t *testing.T) { |
There was a problem hiding this comment.
These two tests use the same configuration, could we merge them into one? The actual assertions in this test aren't very complex, adding them to the first test should be ok.
I'd also consider moving the valuesYaml to a file in testdata/, it's a bit large for an inline value imo.
| @@ -209,3 +220,127 @@ To scrape and forward exposed metrics to Sumo Logic, please follow one of the fo | |||
|
|
|||
| - [Application metrics are exposed (one endpoint scenario)](#application-metrics-are-exposed-one-endpoint-scenario) | |||
| - [Application metrics are exposed (multiple enpoints scenario)](#application-metrics-are-exposed-multiple-enpoints-scenario) | |||
|
|
|||
| ## Metrics modifications | |||
There was a problem hiding this comment.
Can you also update https://github.com/SumoLogic/sumologic-kubernetes-collection/blob/main/docs/best-practices.md#excluding-metrics and other metrics sections in the best practices doc with this new info?
There was a problem hiding this comment.
Should I write more information there or linking to this document will be sufficient?
There was a problem hiding this comment.
I'd provide some examples. It's structurally not the same thing either, as you may want to filter and modify non-application metrics.
sumo-drosiek
force-pushed
the
drosiek-filter-metrics
branch
from
0ff3e03
to
6d2cd03
Compare
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
sumo-drosiek
force-pushed
the
drosiek-filter-metrics
branch
from
bee439d
to
e79a9e6
Compare
Signed-off-by: Dominik Rosiek drosiek@sumologic.com
Description
Fill in your description here.
Checklist
Testing performed