Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClusterName override in Base #273

Merged
merged 1 commit into from Nov 4, 2019
Merged

Conversation

abhi-sumo-zz
Copy link
Contributor

Added the clusterName overrides to the base command so that its easier to get right the first time around.

Description

Fill in your description here.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

Added the clusterName overrides to the base command so that its easier to get right the first time around.
Copy link
Contributor

@rvmiller89 rvmiller89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, it's a lot better to name these than default to kubernetes

@abhi-sumo-zz
Copy link
Contributor Author

@rvmiller89 I, unfortunately, don't have the power to merge. Could you or someone from the collection team merge at your earliest convenience?

Thank you!

@rvmiller89 rvmiller89 merged commit 478d89b into SumoLogic:master Nov 4, 2019
Copy link
Contributor

@samjsong samjsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retrospective LGTM, thanks Abhi for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants