Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjust average utilization for metadata autoscaling #2744

Merged
merged 1 commit into from Jan 4, 2023

Conversation

swiatekm-sumo
Copy link
Contributor

@swiatekm-sumo swiatekm-sumo commented Jan 2, 2023

Description

Adjust average utilization for metadata autoscaling down to 80, the current value of 100 is too aggressive.

Update the documentation to remove any remaining mentions of FluentD autoscaling as well.


Checklist
  • Changelog updated

@github-actions github-actions bot added the documentation documentation label Jan 2, 2023
@swiatekm-sumo swiatekm-sumo marked this pull request as ready for review January 2, 2023 17:05
@swiatekm-sumo swiatekm-sumo requested a review from a team as a code owner January 2, 2023 17:05
@kkujawa-sumo
Copy link
Contributor

Please test this change on OpenShift, I remember that for metics-server enabled on OpenShift we must disable creation of apiService, without

  metrics-server:
    enabled: true
    apiService:
      create: false

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains invalid labels. Please remove all of the following labels: ['do-not-merge/hold']

@swiatekm-sumo
Copy link
Contributor Author

It's not clear if we want to do this at all right now, there are arguments in favor and against, mostly having to do with the pain of ensuring metrics-server is installed.

@swiatekm-sumo
Copy link
Contributor Author

As per #2751, I'm going to switch autoscaling back to disabled by default, and only adjust the average utilization and update documentation.

@swiatekm-sumo swiatekm-sumo changed the title feat!: enable autoscaling for metadata by default feat: adjust average utilization for metadata autoscaling Jan 4, 2023
@swiatekm-sumo swiatekm-sumo merged commit a1f7ab1 into main Jan 4, 2023
@swiatekm-sumo swiatekm-sumo deleted the feat/metadata-autoscaling branch January 4, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants