feat(logs): parse JSON logs #2773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
swiatekm
force-pushed
the
feat/parse-json
branch
from
8197e12
to
e264534
Compare
If so, we should make it configurable or move to separate processor eventually |
swiatekm
force-pushed
the
feat/parse-json
branch
from
e264534
to
edbecd3
Compare
swiatekm
force-pushed
the
feat/parse-json
branch
from
edbecd3
to
bed0f3c
Compare
|
Depends on #2791 |
swiatekm
force-pushed
the
feat/parse-json
branch
from
bed0f3c
to
ebd10f4
Compare
sumo-drosiek
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse JSON logs bodies into OTLP data structures. As a result, Sumo renders the JSON correctly. Without this change, JSON log bodies are just escaped strings.
This change is somewhat dangerous, and I'm wondering if we shouldn't make it possible to disable. The problem is that currently, if the JSON parsing returns an error, it'll result in a 500 returned to the collector, and potentially block the whole batch from being processed indefinitely. Discussion is ongoing in otel upstream about how the errors should be handled, but right now there doesn't seem to be a way to just ignore parse errors.
I've switched to logstransform processor, and this actually lets the malformed data through while logging an error. It seems to be buggy in
0.68.0though, and fine in0.69.0, so this PR shouldn't be merged until we upgrade to the latter.