feat(logs): add format setting #2794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
swiatekm
force-pushed
the
feat/logformat
branch
2 times, most recently
from
0df905e
to
8dfd761
Compare
docs/collecting-container-logs.md
Outdated
Comment on lines
103
to
163
| #### `text` log format | ||
|
|
||
| If you'd like to disable the wrapper, you can do so by setting: | ||
|
|
||
| ```yaml | ||
| sumologic: | ||
| logs: | ||
| container: | ||
| format: text | ||
| ``` | ||
|
|
||
| Then the log lines from the previous section will look like the following in Sumo Logic: | ||
|
|
||
| ```text | ||
| 2007-03-01T13:00:00Z I am a log line | ||
| ``` | ||
|
|
||
| ```javascript | ||
| { | ||
| log_property: "value", | ||
| text: "I am a json log" | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Could you add example without any property as well?
There was a problem hiding this comment.
Do you think that would be helpful? I've already got four examples, fitting in two more makes the whole section less legible in general.
There was a problem hiding this comment.
I rewrote this whole section while adding json_merge.
|
There is one issue related to the text format: https://github.com/SumoLogic/sumologic-kubernetes-collection/blob/main/docs/fluent/troubleshoot-collection.md#using-text-format I don't know why it's only in fluentd troubleshooting though |
swiatekm
force-pushed
the
feat/logformat
branch
from
8dfd761
to
00231d8
Compare
andrzej-stencel
approved these changes
Jan 18, 2023
swiatekm
force-pushed
the
feat/logformat
branch
2 times, most recently
from
bf5568b
to
e2380a3
Compare
swiatekm
force-pushed
the
feat/logformat
branch
from
e2380a3
to
bddd994
Compare
|
Migration: SumoLogic/sumologic-kubernetes-tools#432 |
swiatekm
force-pushed
the
feat/logformat
branch
from
bddd994
to
02dfc41
Compare
andrzej-stencel
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the
logFormatsetting for Fluentd tosumologic.logs.container.format, and make both Fluentd and otel use it.This requires a migration, which I will add shortly.