fix(logs): make built-in metadata consistent between fluentd and otel #2801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
swiatekm
force-pushed
the
fix/source-defaults
branch
2 times, most recently
from
04e1bf6
to
07e3e37
Compare
swiatekm
force-pushed
the
fix/source-defaults
branch
from
07e3e37
to
83546dd
Compare
andrzej-stencel
approved these changes
Jan 19, 2023
swiatekm
force-pushed
the
fix/source-defaults
branch
from
83546dd
to
2760953
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2767 by moving
sumologicschemaprocessor earlier in the pipeline and using translated attributes in source metadata templates instead of native OpenTelemetry ones. In essence we revert part of #2635, and use the old FluentD settings for OT, instead of the other way around.It turns out
sourceprocessorcan't set a source attribute to an empty string, it completely ignores empty templates. So in order to keep things consistent between OT and Fluentd, I needed to set these fields to empty strings in a separate processor. The alternative would be to not send them at all, which is probably fine, but this way we have the exact same output from both pipelines.