fix(logs): correctly handle newlines #2805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `log` key in container or CRI-O does not have a trailing newline
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
andrzej-stencel
force-pushed
the
fix-log-newlines
branch
from
ec629d8
to
5ced774
Compare
andrzej-stencel
force-pushed
the
fix-log-newlines
branch
from
5ced774
to
6a5ff8a
Compare
swiatekm
approved these changes
Jan 18, 2023
Comment on lines
+117
to
+118
| combine_with: |2+ | ||
|
|
There was a problem hiding this comment.
This looks pretty weird, why does it get interpreted as a special character?
There was a problem hiding this comment.
This is just regular Yaml 😉
I looked it up and it seems to be a combination of the "keep" chomping indicator + and the "explicit" indentation indicator 2.
It's actually a bit suspicious, because the next line has no indentation at all, so the 2 seems incorrect 🤔 But hey, the tests pass 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2802, #2803