Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setup as pre-upgrade hook #281

Merged
merged 1 commit into from Nov 8, 2019
Merged

Add setup as pre-upgrade hook #281

merged 1 commit into from Nov 8, 2019

Conversation

maimaisie
Copy link
Contributor

@maimaisie maimaisie commented Nov 7, 2019 •
edited

Description

Adding setup job and RBAC resources as pre-upgrade hooks

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in
  • Verify helm upgrade collection maisie-charts/sumologic --reuse-values succeeds after pushing new chart with a new source added in the terraform file
  • Verify new source is created in Sumo and a new entry for the URL is added in the existing secret

rvmiller89
rvmiller89 approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@rvmiller89 rvmiller89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maimaisie maimaisie merged commit 55b42c7 into master Nov 8, 2019
@maimaisie maimaisie deleted the maisie-pre-upgrade branch November 8, 2019 17:47
@rvmiller89 rvmiller89 mentioned this pull request Nov 8, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvmiller89 rvmiller89 rvmiller89 approved these changes

@samjsong samjsong samjsong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maimaisie @rvmiller89 @samjsong