feat(tracing): bold information about changes #2838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
swiatekm
reviewed
Jan 27, 2023
docs/v3-migration-doc.md
Outdated
| @@ -298,6 +298,7 @@ The above special configuration values can be replaced either to direct values o | |||
|
|
|||
| **When?**: If tracing is enabled | |||
|
|
|||
| **IMPORTANT:** `otelcol` Deployment was moved to `tracesSampler` Deployment. | |||
There was a problem hiding this comment.
How about using
Suggested change
| **IMPORTANT:** `otelcol` Deployment was moved to `tracesSampler` Deployment. | |
| > **Warning** | |
| > `otelcol` Deployment was moved to `tracesSampler` Deployment. |
as per community/community#16925?
There was a problem hiding this comment.
Thanks! :) Applied recommendation
swiatekm
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe better changes for tracing/instrumentation.
Fixes: SumoLogic/sumologic-kubernetes-tools#445
Checklist