chore(metrics): remove deprecated coredns and etcd metrics #2899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
sumo-drosiek
reviewed
Mar 1, 2023
deprecated or removed? Are any of them used by apps? |
Removed. As far as I'm aware, none of these are available in our supported platform versions. And obviously neither apps nor the built-in dashboards and monitors use them. |
swiatekm
force-pushed
the
fix/metrics/controller-manager
branch
from
d7a6559
to
39690a1
Compare
swiatekm
force-pushed
the
fix/metrics/controller-manager
branch
2 times, most recently
from
7555efb
to
5579708
Compare
swiatekm
force-pushed
the
fix/metrics/controller-manager
branch
from
5579708
to
31dcb2f
Compare
sumo-drosiek
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final part of the control plane metrics cleanup. We now don't try to collect any deprecated metrics, and check everything we collect in integration tests.
Checklist