feat: allow setting otelcol image globally #3051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
swiatekm-sumo
force-pushed
the
feat/set-collector-image-globally
branch
from
045fc23
to
3aa2be3
Compare
swiatekm-sumo
force-pushed
the
feat/set-collector-image-globally
branch
from
3aa2be3
to
a824607
Compare
|
I guess this will resolve #2700? |
sumo-drosiek
approved these changes
May 15, 2023
swiatekm-sumo
force-pushed
the
feat/set-collector-image-globally
branch
2 times, most recently
from
8a6ab3c
to
39e19df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new config value for setting otelcol image for all components:
I've also set all the component-specific settings to be empty and the underlying resources will use the default image in this case.
This is implemented with some rather mundane template functions. Most of the added lines are goldenfile tests I've added, that really should've been there to begin with.
Fixes #2700
Checklist