Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add serviceMonitor for metrics collector #3084

Merged
merged 3 commits into from Jun 19, 2023

Conversation

sumo-drosiek
Copy link
Contributor

add serviceMonitor for metrics collector

Checklist

  • Changelog updated or skip changelog label added
  • Documentation updated
  • Template tests added for new features
  • Integration tests added or modified for major features

@sumo-drosiek sumo-drosiek requested a review from a team as a code owner June 15, 2023 06:52
@swiatekm-sumo
Copy link
Contributor

Can you re-add checking for these metrics in the integration test as well? Right now they're manually excluded.

@sumo-drosiek
Copy link
Contributor Author

Can you re-add checking for these metrics in the integration test as well? Right now they're manually excluded.

I need to look at that, but it won't work until the environment variables won't be recognized correctly by target allocator. I may fix it in helm chart by using installation namespace instead of env variable

Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
@sumo-drosiek sumo-drosiek force-pushed the drosiek-otelmetrics-service-monitor branch from 47677b0 to 8838220 Compare June 15, 2023 09:16
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
@sumo-drosiek sumo-drosiek force-pushed the drosiek-otelmetrics-service-monitor branch 2 times, most recently from b953107 to 1e3a96c Compare June 15, 2023 15:25
@sumo-drosiek sumo-drosiek force-pushed the drosiek-otelmetrics-service-monitor branch from 1e3a96c to b6a2efa Compare June 15, 2023 15:35
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
@sumo-drosiek sumo-drosiek force-pushed the drosiek-otelmetrics-service-monitor branch from b6a2efa to 5b763c9 Compare June 15, 2023 15:35
@sumo-drosiek sumo-drosiek merged commit c3079ed into main Jun 19, 2023
53 checks passed
@sumo-drosiek sumo-drosiek deleted the drosiek-otelmetrics-service-monitor branch June 19, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants