Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Otel cloudwatch logs collector fixes #3099

Merged
merged 2 commits into from Jul 6, 2023
Merged

Otel cloudwatch logs collector fixes #3099

merged 2 commits into from Jul 6, 2023

Conversation

rnishtala-sumo
Copy link
Contributor

@rnishtala-sumo rnishtala-sumo commented Jun 23, 2023 •
edited

  • Fixing PVC name for the cloudwatch logs collector - to not hardcode the release name
  • Correct the name of the EFS access points
  • Changelog updated or skip changelog label added
  • Documentation updated

@github-actions github-actions bot added the documentation documentation label Jun 23, 2023
@rnishtala-sumo rnishtala-sumo changed the title Otel cloudwatch fixes Otel cloudwatch logs collector fixes Jun 23, 2023
@rnishtala-sumo rnishtala-sumo marked this pull request as ready for review July 5, 2023 22:11
@rnishtala-sumo rnishtala-sumo requested a review from a team as a code owner July 5, 2023 22:11
sumo-drosiek
sumo-drosiek approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Do we need to update example script?

@swiatekm-sumo
Copy link
Contributor

I'm going to merge this so it can go into 3.10.0. We can update the example script separately if need be.

@swiatekm-sumo swiatekm-sumo merged commit 4ee2602 into main Jul 6, 2023
40 checks passed
@swiatekm-sumo swiatekm-sumo deleted the otel-cloudwatch-fixes branch July 6, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions approved these changes

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

@swiatekm-sumo swiatekm-sumo swiatekm-sumo approved these changes

Assignees
No one assigned
Labels
documentation documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnishtala-sumo @swiatekm-sumo @sumo-drosiek