feat(metrics): split metadata extraction from otel collector #3122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
swiatekm-sumo
force-pushed
the
feat/metrics/split-collector-metadata
branch
from
795db82
to
35380cb
Compare
swiatekm-sumo
force-pushed
the
feat/metrics/split-collector-metadata
branch
from
35380cb
to
7096b20
Compare
swiatekm-sumo
force-pushed
the
feat/metrics/split-collector-metadata
branch
from
7096b20
to
c0a475f
Compare
sumo-drosiek
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the otel metrics collector strictly replace Prometheus, and keep the metadata StatefulSet separate. Originally I'd wanted to simplify the architecture by merging these two components, but this ended up making the migration more complicated and difficult to understand. We can do the architectural changes separately, in a future release.
Checklist