fix(metrics/collector): drop k8s labels #3141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
swiatekm-sumo
force-pushed
the
fix/metrics/collector-default-labels
branch
from
2dd0087
to
2829b8a
Compare
swiatekm-sumo
force-pushed
the
fix/metrics/collector-default-labels
branch
from
2829b8a
to
7288299
Compare
swiatekm-sumo
force-pushed
the
fix/metrics/collector-default-labels
branch
from
7288299
to
7232cb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prometheus receiver adds some attributes based on Prometheus' meta labels. This cannot be turned off explicitly or prevented by deleting the labels in relabel configs, because the labels are extracted from the context.
Drop these labels in a processor, as we don't need them, and their presence makes the pipeline more difficult to understand.
I've also added a test specifically for metadata of kube-state-metrics, which have specific requirements. For example, Prometheus incorrectly assigns Pod metadata to them, and the test checks whether we remove it.
Checklist