Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): do not filter in default remote write definitions #3157

Merged
merged 1 commit into from Jul 21, 2023

Conversation

swiatekm-sumo
Copy link
Contributor

@swiatekm-sumo swiatekm-sumo commented Jul 17, 2023

Merge most of the default remote writes into a single one that does (almost) no data transformations. We filter by job name instead of metric name.

  • Node metrics still have their own, due to difficulty handling recording rule metrics.
  • Collection internal metrics need some additional work before they can be handled this way.
  • We need to manually drop Prometheus' scrape metrics.

This doesn't affect users who modified these, as that requires overriding the whole array, and this is therefore not a breaking change.

Checklist

  • Changelog updated or skip changelog label added
  • Documentation updated
  • Template tests added for new features
  • Integration tests added or modified for major features

@swiatekm-sumo swiatekm-sumo force-pushed the feat/metrics/remote-write-no-filter branch from bf1b9ca to db99de5 Compare July 18, 2023 17:01
@swiatekm-sumo swiatekm-sumo force-pushed the feat/metrics/remote-write-no-filter branch from 26f7370 to ff3a264 Compare July 19, 2023 13:43
@swiatekm-sumo swiatekm-sumo force-pushed the feat/metrics/remote-write-no-filter branch 4 times, most recently from 8bb8924 to b41cc25 Compare July 20, 2023 12:12
@swiatekm-sumo swiatekm-sumo force-pushed the feat/metrics/remote-write-no-filter branch from b41cc25 to 42a9884 Compare July 20, 2023 12:52
@swiatekm-sumo swiatekm-sumo force-pushed the feat/metrics/remote-write-no-filter branch 2 times, most recently from cab0c45 to e2bcab0 Compare July 20, 2023 15:56
@swiatekm-sumo swiatekm-sumo force-pushed the feat/metrics/remote-write-no-filter branch from e2bcab0 to d229ad4 Compare July 20, 2023 15:57
@swiatekm-sumo swiatekm-sumo marked this pull request as ready for review July 21, 2023 10:12
@swiatekm-sumo swiatekm-sumo requested a review from a team as a code owner July 21, 2023 10:12
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for me. It would be nice to have some comparison e2e 😅
maybe some day

@swiatekm-sumo swiatekm-sumo merged commit d92a00c into main Jul 21, 2023
41 checks passed
@swiatekm-sumo swiatekm-sumo deleted the feat/metrics/remote-write-no-filter branch July 21, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants