feat(metrics): disable default Prometheus rules #3160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
swiatekm-sumo
force-pushed
the
feat/disable-default-prometheus-rules
branch
from
fc4f30d
to
2240b22
Compare
swiatekm-sumo
commented
Jul 20, 2023
| @@ -359,6 +359,7 @@ var ( | |||
| "otelcol_otelsvc_k8s_pod_deleted", | |||
| "otelcol_processor_batch_batch_size_trigger_send", | |||
| "otelcol_otelsvc_k8s_ip_lookup_miss", | |||
| "otelcol_otelsvc_k8s_other_deleted", | |||
There was a problem hiding this comment.
This is unrelated, just another flaky metric I found running tests locally.
sumo-drosiek
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kube-prometheus-stack installs a bunch of alerting and recording rules by default, of which we use two for our own recording rules. The rest aren't necessary and make filtering existing metrics more difficult.
We don't support any of these, so it's not a breaking change, but I've called it out in the changelog for users who may have configured kube-prometheus-stack to use these.
Checklist