feat(metrics): remove collection metrics remote write #3161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
swiatekm-sumo
force-pushed
the
feat/metrics/collection-remotewrite
branch
from
71e4193
to
be32e3e
Compare
swiatekm-sumo
force-pushed
the
feat/metrics/collection-remotewrite
branch
2 times, most recently
from
6047491
to
40aa3ce
Compare
swiatekm-sumo
force-pushed
the
feat/metrics/collection-remotewrite
branch
from
40aa3ce
to
028996c
Compare
swiatekm-sumo
force-pushed
the
feat/metrics/collection-remotewrite
branch
from
028996c
to
4e96ce1
Compare
sumo-drosiek
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the remote write for collection metrics and have those metrics use the default remote write. This is a bit tricky as Fluent Bit and Prometheus Services are created by dependency Charts and don't follow our naming conventions. It also turned out we had an unnecessary Prometheus ServiceMonitor, which I fixed.
Checklist