fix(metrics): don't forward duplicate metrics from annotated Pods #3171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
swiatekm-sumo
force-pushed
the
fix/metric/duplicate-app-metrics
branch
4 times, most recently
from
b31abb6
to
d957829
Compare
swiatekm-sumo
force-pushed
the
fix/metric/duplicate-app-metrics
branch
from
d957829
to
bbf017a
Compare
| @@ -38,7 +38,7 @@ processors: | |||
| metrics: | |||
| metric: | |||
| # we let the metrics from annotations ("kubernetes-pods") through as they are | |||
There was a problem hiding this comment.
Suggested change
| # we let the metrics from annotations ("kubernetes-pods") through as they are | |
| # we let the metrics from annotations ("pod-annotations") through as they are |
Comment on lines
-416
to
-418
| internal.ReceiverMockNamespace, | ||
| internal.ReceiverMockServiceName, | ||
| internal.ReceiverMockServicePort, |
There was a problem hiding this comment.
We are not going to check receiver-mock metrics anymore?
There was a problem hiding this comment.
This doesn't change any of the test checks, I just moved this logic to a separate function which gets these values from module constants.
There was a problem hiding this comment.
I do want to get rid of checking for receiver-mock metrics, because they're annoying to work with - receiver-mock only emits some of them based on ingested data, so they're different for each test - but I didn't do that in this PR.
sumo-drosiek
approved these changes
Jul 28, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't forward App metrics if they originate from a Pod scraped due to annotations. We tell customers to do this for these metrics (https://help.sumologic.com/docs/integrations/web-servers/nginx/#configure-metrics-collection), but we have separate remote writes for these cases, and so they are forwarded twice, and with different labels.
I ended up making a bunch of additional changes:
Checklist