fix(otellogs): fix configuration for filelog/container to use default settings for fingerprint_size on k8s >=1.24 #3185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… settings for fingerprint_size on k8s >=1.24 When fingerprint_size is set to 1kb (default value) the issue with duplicated logs is not observed ref: open-telemetry/opentelemetry-collector-contrib#22936
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
swiatekm-sumo
approved these changes
Aug 3, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix configuration for filelog/container to use default settings for
fingerprint_sizeon k8s >=1.24Problem with previous form of condition was observed on EKS 1.24 (I see tests for this condition so it looks like there is different form of
.Capabilities.KubeVersion.Minoron EKS) - this pull request useskubernetes.minorfunction which is used in other places in our Helm ChartWhen fingerprint_size is set to 1kb (default value) the issue with duplicated logs is not observed, open-telemetry/opentelemetry-collector-contrib#22936
Checklist